Beds 526/Raw DB sdk #947

Tangui-Bitfly · 2024-10-14T10:02:59Z

add db2.BigTableEthRaw which only purpose is reading from the raw bigtable store
db2.BigTableEthRaw is a http.RoundTriper, this allow the caller to use when creating a new ethclient.Client
introduce the db2.RawStore to handle all interaction with bigtable satore. There are some duplications here, the aim of this pr is not to refactor everything, it's just to provide an easy to use way of retrieving eth data from bigtable
it is used as follow

bt, err := store.NewBigTableWithClient(context.Background(), client, admin, raw)
if err != nil {
	t.Fatal(err)
}

rawStore := NewRawStore(store.Wrap(bt, BlocRawTable, ""))

rpcClient, err := rpc.DialOptions(context.Background(), "http://foo.bar", rpc.WithHTTPClient(&http.Client{
	Transport: NewBigTableEthRaw(rawStore, chainID),
}))
ethClient := ethclient.NewClient(rpcClient)

db2/BigTableEthRaw: add chainID db2/BigTableEthRaw: handle index for get uncle db2/BigTableEthRaw: fix with empty tx db2/BigTableEthRaw: add real condition test db2/BigTableEthRaw: add WithFallback db2/BigTableEthRaw: fallback for unsupported method db2: add cache to raw store (#966) db2: better cache + client + update store bigtable + clean up db2/raw: add EthParse

Monika-Bitfly · 2024-11-19T16:50:07Z

backend/internal/contracts/README.md

+
+- solc is available [here](https://docs.soliditylang.org/en/latest/installing-solidity.html)
+
+- and `abigen` wan be installed through go directly


Suggested change

- and `abigen` wan be installed through go directly

- and `abigen` can be installed through go directly

Monika-Bitfly · 2024-11-19T16:57:18Z

backend/internal/th/ethereum.go

+
+	head, _ := b.Backend.Client().HeaderByNumber(context.Background(), nil)
+	gasPrice := new(big.Int).Add(head.BaseFee, big.NewInt(params.GWei))
+	chainid, _ := b.Backend.Client().ChainID(context.Background())


Suggested change

chainid, _ := b.Backend.Client().ChainID(context.Background())

chainid, err := b.Backend.Client().ChainID(context.Background())

Monika-Bitfly · 2024-11-19T17:02:34Z

backend/internal/th/ethereum.go

+func (b *BlockchainBackend) MakeUnsignedTx(t *testing.T, from common.Address, to *common.Address, value *big.Int, data []byte) *types.Transaction {
+	t.Helper()
+
+	head, _ := b.Backend.Client().HeaderByNumber(context.Background(), nil)


Suggested change

head, _ := b.Backend.Client().HeaderByNumber(context.Background(), nil)

head, err := b.Backend.Client().HeaderByNumber(context.Background(), nil)

we should check for any errors coz we will be accessing the BaseFee value to calculate the gas price

Monika-Bitfly · 2024-11-19T17:03:11Z

backend/internal/th/ethereum.go

+func (b *BlockchainBackend) DeployContract(t *testing.T, contractData []byte) common.Address {
+	t.Helper()
+
+	head, _ := b.Backend.Client().HeaderByNumber(context.Background(), nil)


Suggested change

head, _ := b.Backend.Client().HeaderByNumber(context.Background(), nil)

head, err := b.Backend.Client().HeaderByNumber(context.Background(), nil)

Monika-Bitfly · 2024-11-19T17:03:22Z

backend/internal/th/ethereum.go

+
+	head, _ := b.Backend.Client().HeaderByNumber(context.Background(), nil)
+	gasPrice := new(big.Int).Add(head.BaseFee, big.NewInt(params.GWei))
+	chainid, _ := b.Backend.Client().ChainID(context.Background())


Suggested change

chainid, _ := b.Backend.Client().ChainID(context.Background())

chainid, err := b.Backend.Client().ChainID(context.Background())

Monika-Bitfly · 2024-11-19T17:07:29Z

backend/internal/th/ethereum.go

+	bk := ethsimtracer.NewBackend(genesis, func(nodeConf *node.Config, ethConf *ethconfig.Config) {
+		nodeConf.HTTPModules = append(nodeConf.HTTPModules, "debug", "eth")
+		nodeConf.HTTPHost = "127.0.0.1"
+		nodeConf.HTTPPort = 4242


It might be a good idea to move the port value to the top of the file and store it as a constant - it will make it easier to update when needed

Monika-Bitfly · 2024-11-19T17:18:03Z

backend/pkg/commons/db2/database/bigtable.go

+		return fmt.Errorf("cannot ApplyBulk err: %w", err)
+	}
+	// TODO aggregate errs
+	for _, e := range errs {


Suggested change

for _, e := range errs {

var bulkErrs []string

for _, e := range errs {

bulkErrs = append(bulkErrs, e.Error())

}

if len(bulkErrs) > 0 {

return fmt.Errorf("cannot ApplyBulk elem, errors: %v", bulkErrs)

}

Monika-Bitfly · 2024-11-19T17:18:16Z

backend/pkg/commons/db2/database/bigtable.go

+	if err != nil {
+		return fmt.Errorf("cannot ApplyBulk err: %w", err)
+	}
+	// TODO aggregate errs


Suggested change

// TODO aggregate errs

Monika-Bitfly · 2024-11-19T17:22:57Z

backend/pkg/commons/db2/database/bigtable.go

+// Close shuts down the BigTable by closing the Bigtable client connection
+// It returns an error if the operation fails
+func (b BigTable) Close() error {
+	if err := b.client.Close(); err != nil && status.Code(err) != codes.Canceled {


let's also check if the client is not nil before trying to close it

Monika-Bitfly · 2024-11-19T17:31:50Z

backend/pkg/commons/db2/database/bigtable_test.go

+			}, {
+				key: "bar",
+			}},
+			expected: []string{"", "", "", ""},


is this correct expected output?

Monika-Bitfly · 2024-11-19T17:49:50Z

backend/pkg/commons/db2/databasetest/bigtable.go

+	if err != nil {
+		t.Fatal(err)
+	}
+	ctx := context.Background()


Suggested change

ctx := context.Background()

ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second)

defer cancel()

Monika-Bitfly · 2024-11-19T18:04:54Z